build: migrate to SDK-V2

[melsener]

Change description

Migrate to TeamsJS-V2.

You can review this PR commit-by-commit.

• The first commit consists of the automatic changes made by Teams Toolkit (see Reference-1) to update the SDK. Along with updating some code, it adds some TODOs for us.
• The later five commits handle those TODOs
• The next one updates the SDK and manifest to the recommended version (see Reference-2)
• The next commit updates the login flow due to the change in the authentication method (See Reference-3 and 4)
• The next commit removes early returns in case of undefined since this was also possible in the previous version (see Reference-5 and 6)

References:

1. Updating via Teams Toolkit
2. Existing teams apps - SDK and Manifest recommended versions
3. AuthenticateParameters interface on v1.11.0 and deprecation warning
4. Authenticate Popup Parameters interface docs
5. Updates to Context interface
6. Context interface on v1.11.0

Type of change

• Bug fix (fixes an issue)
• New feature (adds functionality)

Checklists

Development

• Lint rules pass locally
• Application changes have been tested thoroughly
• Automated tests covering modified code pass

Security

• Security impact of change has been considered
• Code follows company security practices and guidelines

Code review

• Pull request has a descriptive title and it follows conventional commit format and breaking change indicator if required (You can use the Angular convention)
• Screenshots or screencasts are attached as necessary
• "Ready for review" label attached and reviewers assigned
• Changes have been reviewed by at least one other contributor
• Pull request linked to task tracker where applicable

[dorukgunes]

Did we have a change to test it with old ms teams ?

[dorukgunes]

Nothing important but, should we also update to async, await style to improve readability ?

[melsener]

since we're using it inside useEffect this version seems to provide a better readability to me. you can see the alternatives here: https://devtrium.com/posts/async-functions-useeffect

[melsener]

Did we have a change to test it with old ms teams ?

yes @dorukgunes however, I couldn't test it with new ms-teams and teams cloud due to the issues on their side.

[aykutbulca]

Let's not merge it until we make sure we can publish a new manifest (aka, we have the dx account permissions back).