Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upgrade mongoose #190

Merged
merged 2 commits into from
Dec 8, 2023
Merged

feat: upgrade mongoose #190

merged 2 commits into from
Dec 8, 2023

Conversation

berkay-dincer
Copy link
Member

Change description

Upgrade mongoose, update ci pipeline to use mongodb 5.0.20

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and it follows conventional commit format and breaking change indicator if required (You can use the Angular convention)
  • Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

aykutbulca
aykutbulca reviewed Dec 4, 2023
View reviewed changes
package.json
@@ -72,7 +72,6 @@
"@types/hapi__joi": "^17.1.4",
"@types/jest": "^26.0.5",
"@types/mongodb": "^3.5.25",
"@types/mongoose": "^5.7.34",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this not needed anymore?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

types are included in mongoose 5.11.0

dorukgunes
dorukgunes reviewed Dec 4, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
yuqu
yuqu reviewed Dec 4, 2023
View reviewed changes
Copy link
Contributor

@yuqu yuqu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after Doruk's comment

@berkay-dincer berkay-dincer merged commit 36ecd53 into main Dec 8, 2023
1 check passed
@berkay-dincer berkay-dincer deleted the feat/mongoose-upgrade branch December 8, 2023 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aykutbulca aykutbulca aykutbulca approved these changes

@melsener melsener melsener approved these changes

@yuqu yuqu yuqu approved these changes

@dorukgunes dorukgunes dorukgunes approved these changes

@yuksely yuksely Awaiting requested review from yuksely

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@berkay-dincer @dorukgunes @yuqu @melsener @aykutbulca