chore: remove try catch

zeplin · Mar 7, 2024 · b968475 · b968475
1 parent b28a27c
commit b968475
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/src/client/containers/LoginContainer/LoginContainer.tsx b/src/client/containers/LoginContainer/LoginContainer.tsx
@@ -22,9 +22,13 @@ export const LoginContainer: FunctionComponent = () => {
     const { isInitializeLoading } = useInitialize();
     const [login, { loginError }] = useLogin({
         onSuccess: async (code?: string) => {
-            const { accessToken, refreshToken } = await requester.createAuthToken(String(code));
-            storage.setAccessToken(accessToken);
-            storage.setRefreshToken(refreshToken);
+            try {
+                const { accessToken, refreshToken } = await requester.createAuthToken(String(code));
+                storage.setAccessToken(accessToken);
+                storage.setRefreshToken(refreshToken);
+            } catch (err) {
+                // TODO: log to sentry
+            }
             replace(id
                 ? url.getConfigurationUpdateUrl({
                     channel: channel as string,

diff --git a/src/client/containers/ZeplinAuthEndContainer/ZeplinAuthEndContainer.tsx b/src/client/containers/ZeplinAuthEndContainer/ZeplinAuthEndContainer.tsx
@@ -18,11 +18,7 @@ export const ZeplinAuthEndContainer: FunctionComponent = () => {
                 return;
             }
 
-            try {
-                microsoftTeams.authentication.notifySuccess(code as string);
-            } catch (tokenError) {
-                microsoftTeams.authentication.notifyFailure((tokenError as Error)?.message ?? `Unknown error ${tokenError}`);
-            }
+            microsoftTeams.authentication.notifySuccess(code as string);
         });
     }, []);