tests: kernel: metairq: Ensure meta-IRQ can preempt a cooperative thread #84509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The intention of the test is to have a meta-IRQ preempt a cooperative thread, then ensure the same cooperative thread is resumed back to instead of a higher priority thread. Thus, the test needs to assert that the lower priority cooperative thread is not yet complete when it makes the higher priority thread ready to run. This change reveals bugs like zephyrproject-rtos#80574, where the meta-IRQ is unable to preempt a cooperative thread. Signed-off-by: Kalle Kietäväinen <[email protected]>
zephyrbot
requested review from
andyross,
ceolin,
cfriedt,
dcpleung,
nashif,
npitre,
peter-mitsis and
TaiJuWu
andyross
approved these changes
Jan 24, 2025
nashif
reviewed
Jan 24, 2025
| @@ -113,6 +115,8 @@ void coop_thread1(void *p1, void *p2, void *p3) | |||
| cnt2 = coop_cnt2; | |||
| zassert_equal(cnt2, LOOP_CNT, "Unexpected cnt2 at end: %d", cnt2); | |||
|
|
|||
| printk("thread1 end\n"); | |||
There was a problem hiding this comment.
debug code? Do we need this in the test?
There was a problem hiding this comment.
Not necessarily. As the cooperative thread already printed when it ended, I added these for the other two threads. It also makes the failure case more clear in the logs, I think:
Running TESTSUITE suite_preempt_metairq
===================================================================
START - test_preempt_metairq
thread1 take sem
thread2 take sem
metairq start
give sem2
thread2 got sem
thread2 loop iteration 0
thread2 loop iteration 1
thread2 loop iteration 2
thread2 loop iteration 3
thread2 end
Assertion failed at WEST_TOPDIR/zephyr/tests/kernel/sched/metairq/src/main.c:80: metairq_thread: (coop_cnt2 equal to LOOP_CNT)
thread2 wasn't preempted
FAIL - test_preempt_metairq in 0.065 seconds
peter-mitsis
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intention of the test is to have a meta-IRQ preempt a cooperative thread, then ensure the same cooperative thread is resumed back to instead of a higher priority thread. Thus, the test needs to assert that the lower priority cooperative thread is not yet complete when it makes the higher priority thread ready to run.
This change reveals bugs like #80574, where the meta-IRQ is unable to preempt a cooperative thread.
Important
This improves existing test case to reveal #80574, but doesn't fix the issue. The meta-IRQ test should start failing on Cortex-M with this.