Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boards: weact: Add support for WeAct STM32H5 Core Board #84180

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

boards: weact: Add support for WeAct STM32H5 Core Board #84180

wants to merge 2 commits into from
+517 −0

Conversation

magiczny-kacper
Copy link

Low cost STM32H5 series development board with bare minimum to run the MCU

@zephyrbot zephyrbot added the platform: STM32 ST Micro STM32 label Jan 17, 2025
@github-actions GitHub Actions
Copy link

Hello @magiczny-kacper, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

@JarmouniA
Copy link
Collaborator

Hi @magiczny-kacper, thanks for your contribution. Please see remarks in PR #84033 and apply the relevant ones here. Also squash the last 2 commits, and preferably put the SoC dtsi definition in a separate commit.

@JarmouniA
Copy link
Collaborator

@magiczny-kacper the 1st commit title should be dts: st: h5: add STM32H562xG SoC support

@magiczny-kacper
dts: st: h5: addSTM32H562xG SoC support
522658c 
Added STM32H562xG dts file

Signed-off-by: Kacper Brzostowski <[email protected]>
@magiczny-kacper magiczny-kacper force-pushed the weact_h5_core branch 2 times, most recently from 5bf7914 to 00aa596 Compare January 19, 2025 11:31
nordicjm
nordicjm reviewed Jan 20, 2025
View reviewed changes
boards/weact/stm32h5_core/doc/index.rst Outdated
Supported Features
==================

The Zephyr nucleo_h563zi board configuration supports the following hardware features:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The Zephyr nucleo_h563zi board configuration supports the following hardware features:
The Zephyr ``weact_stm32h5_core`` board supports the following hardware features:

boards/weact/stm32h5_core/weact_stm32h5_core.dts Outdated
status = "okay";
pinctrl-0 = <&usart1_tx_pa9 &usart1_rx_pa10>;
pinctrl-names = "default";

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

boards/weact/stm32h5_core/weact_stm32h5_core.dts
label = "mcuboot";
reg = <0x00000000 DT_SIZE_K(64)>;
};
slot0_partition: partition@10000 {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inconsistent spacing in file at this point

@magiczny-kacper magiczny-kacper force-pushed the weact_h5_core branch 7 times, most recently from 5f8f686 to ffcdc29 Compare January 23, 2025 15:35
@zephyrbot zephyrbot added area: ADC Analog-to-Digital Converter (ADC) area: DAC Digital-to-Analog Converter labels Jan 23, 2025
JarmouniA
JarmouniA reviewed Jan 23, 2025
View reviewed changes
tests/drivers/adc/adc_api/boards/weact_stm32h5_core.overlay Outdated
Copy link
Collaborator

@JarmouniA JarmouniA Jan 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to add this board too to CI, H5 ADC & DAC are already covered by NUCLEO_H563ZI, just remove the adc & dac tags from weact_stm32h5_core.yaml, or add them under testing: ignore_tags: see https://docs.zephyrproject.org/latest/develop/test/twister.html

@JarmouniA JarmouniA removed area: ADC Analog-to-Digital Converter (ADC) area: DAC Digital-to-Analog Converter labels Jan 23, 2025
@zephyrbot zephyrbot added the area: ADC Analog-to-Digital Converter (ADC) label Jan 23, 2025
@zephyrbot zephyrbot requested a review from anangl January 23, 2025 17:02
JarmouniA
JarmouniA suggested changes Jan 23, 2025
View reviewed changes
boards/weact/stm32h5_core/doc/index.rst Outdated
.. _STM32CubeProgrammer:
https://www.st.com/en/development-tools/stm32cubeprog.html

.. _OpenOCD official Github mirror:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not used

@JarmouniA JarmouniA removed the request for review from anangl January 23, 2025 17:24
@JarmouniA JarmouniA removed the area: ADC Analog-to-Digital Converter (ADC) label Jan 23, 2025
@magiczny-kacper magiczny-kacper force-pushed the weact_h5_core branch 2 times, most recently from 1dc251e to 0c198ee Compare January 23, 2025 18:09
JarmouniA
JarmouniA suggested changes Jan 23, 2025
View reviewed changes
boards/weact/stm32h5_core/doc/index.rst Outdated
https://www.st.com/resource/en/reference_manual/rm0481-stm32h52333xx-stm32h56263xx-and-stm32h573xx-armbased-32bit-mcus-stmicroelectronics.pdf

.. _STMicroelectronics OpenOCD Github:
https://github.com/STMicroelectronics/OpenOCD/tree/openocd-cubeide-r6
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still not removed

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, forgot to add it to commit

JarmouniA
JarmouniA suggested changes Jan 24, 2025
View reviewed changes
boards/weact/stm32h5_core/weact_stm32h5_core.yaml
- xtools
ram: 640
flash: 1024
supported:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I didn't catch this before, we only put tags here for devices that are enabled in board DTS, I don't see any SPI, I3C, CAN,.. nodes.

JarmouniA
JarmouniA approved these changes Jan 24, 2025
View reviewed changes
Copy link
Collaborator

@JarmouniA JarmouniA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks!

@magiczny-kacper magiczny-kacper force-pushed the weact_h5_core branch 2 times, most recently from 327c30e to 162ad43 Compare January 24, 2025 14:07
@magiczny-kacper
boards: weact: Add support for WeAct STM32H5 Core Board
25e5909 
Low cost STM32H5 series development board with bare minimum to run the MCU

Signed-off-by: Kacper Brzostowski <[email protected]>
@magiczny-kacper
Copy link
Author

magiczny-kacper commented Jan 24, 2025 •
edited
Loading

@JarmouniA thank you too! I have fixed typos to pass CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JarmouniA JarmouniA JarmouniA approved these changes

@djiatsaf-st djiatsaf-st Awaiting requested review from djiatsaf-st

@erwango erwango Awaiting requested review from erwango

@FRASTM FRASTM Awaiting requested review from FRASTM

@gautierg-st gautierg-st Awaiting requested review from gautierg-st

@GeorgeCGV GeorgeCGV Awaiting requested review from GeorgeCGV

@marwaiehm-st marwaiehm-st Awaiting requested review from marwaiehm-st

@mathieuchopstm mathieuchopstm Awaiting requested review from mathieuchopstm

@nordicjm nordicjm Awaiting requested review from nordicjm

At least 2 approving reviews are required to merge this pull request.

Assignees

@erwango erwango

Labels
area: Boards platform: STM32 ST Micro STM32
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@magiczny-kacper @JarmouniA @nordicjm @erwango @zephyrbot