[drivers][gpio]: Support TCA9536 #84057
Open
+6
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: GPIO
platform: TI SimpleLink
zephyrbot
requested review from
henrikbrixandersen,
mnkp,
vaishnavachath and
vanti
RafaelLaya
force-pushed
the
tca9536_support
branch
2 times, most recently
from
e244497 to
4a6d047
Compare
|
Bump |
|
@RafaelLaya now that user can put any ngpios, should the driver check for valid inputs (8 or 4) and handle errors accordingly? also can you update the commit title to follow the pattern followed in the subsystem ? do a |
RafaelLaya
force-pushed
the
tca9536_support
branch
from
4a6d047 to
9cfdc3b
Compare
|
Thanks! I've addressed validation with a build-assert checking for 4 or 8 on the gpios property and fixed the git commit title |
RafaelLaya
force-pushed
the
tca9536_support
branch
from
9cfdc3b to
f17515a
Compare
|
Latest version fixes syntax error introduced on the previous revision |
|
Any reviewers? |
RafaelLaya
force-pushed
the
tca9536_support
branch
from
f17515a to
69756c8
Compare
|
Rebased |
RafaelLaya
force-pushed
the
tca9536_support
branch
from
69756c8 to
41e78d4
Compare
The PCA953x driver supports the TCA953x family To properly support TCA953x, we need to allow ngpios!=8 This change allows this posibility in the driver Signed-off-by: Rafael Laya <[email protected]>
RafaelLaya
force-pushed
the
tca9536_support
branch
from
41e78d4 to
27e0b75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PCA953x driver supports the TCA953x family of GPIO expanders from TI. Currently, it makes the assumption that there are always 8 pins on the module. However, the variant TCA9536 is identical to TCA9538 except it only has 4 output pins.
To properly support TCA953x, we need to allow for a number of GPIOs that aren't 8. This change allows this in the driver.
There seem to be no DTS definitions in the Zephyr tree where
ngpiosisn't explicitly selected for this driver, so no definitions are changing besides just the driver in this PR.