Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boards: shields: Change the property names in the overlay #83840

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

boards: shields: Change the property names in the overlay #83840

wants to merge 1 commit into from
+5 −5

Conversation

rruuaanng
Copy link
Collaborator

Unify property names in bindings and overrides, using hyphens (-) instead of underscores (_) as separators.

@rruuaanng
boards: shields: Change the property names in the overlay
6966343 
Unify property names in bindings and overrides, using
hyphens (-) instead of underscores (_) as separators.

Signed-off-by: James Roy <[email protected]>
@rruuaanng rruuaanng mentioned this pull request Jan 11, 2025
Open
18 tasks
@rruuaanng rruuaanng marked this pull request as ready for review January 11, 2025 09:11
@zephyrbot zephyrbot added area: Display area: Shields Shields (add-on boards) labels Jan 11, 2025
kartben
kartben requested changes Jan 11, 2025
View reviewed changes
Copy link
Collaborator

@kartben kartben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is missing a entry in migration guide, you can't just rename properties without documenting it, this will break downstream users.
also commit message should be "drivers: display: ..." imo, the "root" change is in the display bindings, not in shields

@rruuaanng
Copy link
Collaborator Author

this is missing a entry in migration guide, you can't just rename properties without documenting it, this will break downstream users.

also commit message should be "drivers: display: ..." imo, the "root" change is in the display bindings, not in shields

This PR is just a sub-PR of #83352.

@kartben kartben mentioned this pull request Jan 11, 2025
Open
@rruuaanng
Copy link
Collaborator Author

Because the commit was too large, I needed to split it. Additionally, I will modify the commit messages later.

@kartben kartben mentioned this pull request Jan 11, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kartben kartben kartben requested changes

@avisconti avisconti Awaiting requested review from avisconti

@danieldegrasse danieldegrasse Awaiting requested review from danieldegrasse

@erwango erwango Awaiting requested review from erwango

@jfischer-no jfischer-no Awaiting requested review from jfischer-no

Requested changes must be addressed to merge this pull request.

Assignees

@kartben kartben

Labels
area: Display area: Shields Shields (add-on boards)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rruuaanng @kartben @zephyrbot