net: http_server: allow specifying a default resource #83811
+105
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The _detail parameter of HTTP_SERVICE_DEFINE is used to optionally specify a default resource detail, which will be served if no other resource matches the URL. Signed-off-by: Matt Rodgers <[email protected]>
|
Should we mention about this also in the API documentation which has examples of the usage? |
rlubos
previously approved these changes
Jan 10, 2025
|
Added some documentation for this change |
rlubos
previously approved these changes
Jan 10, 2025
Add documentation showing how to use the _detail parameter when registering an HTTP service to provide a default resource handling any unknown path. Signed-off-by: Matt Rodgers <[email protected]>
mrodgers-witekio
force-pushed
the
http_server_default_resource
branch
from
94fb189 to
9f9b19b
Compare
rlubos
approved these changes
Jan 10, 2025
|
It would be great to provide a page that can be used to communicate any HTTP status code, and Zephyr could provide one that users could choose to use. Default might not be the best terminology, but I think the idea is good. |
cfriedt
reviewed
Jan 10, 2025
| const struct http_request_ctx *request_ctx, | ||
| struct http_response_ctx *response_ctx, void *user_data) | ||
| { | ||
| static const char response_404[] = "Oops, page not found!"; |
There was a problem hiding this comment.
Is it possible to reuse this in a more generic way for any HTTP error?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
_detailparameter ofHTTP_SERVICE_DEFINEis currently unused - use this to allow specifying a default resource detail which will be served if no other resource is matched. If the parameter isNULL, the existing behaviour is retained.This could be used to: