Bluetooth: BAP: Add a set of suggested intervals to use with BAP #81093
+348
−269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thalley
changed the title
Thalley
force-pushed
the
audio_interval_macros
branch
3 times, most recently
from
ad61f81 to
b94bd7b
Compare
Thalley
commented
Nov 9, 2024
Thalley
commented
Nov 9, 2024
Thalley
force-pushed
the
audio_interval_macros
branch
from
b94bd7b to
f4f3960
Compare
Thalley
force-pushed
the
audio_interval_macros
branch
from
f4f3960 to
60198f5
Compare
zephyrbot
added
area: Samples
zephyrbot
requested review from
asbjornsabo,
babrsn,
Casper-Bonde-Bose,
fredrikdanebjer,
jhedberg,
jthm-ot,
kartben,
kruithofa,
larsgk,
MariuszSkamra,
nashif,
niym-ot,
pin-zephyr and
sjanc
|
@cvinayak updated the PR with your fixed, and changed the adv interval to 150ms for periodic and 140ms for extended |
cvinayak
reviewed
Dec 7, 2024
Thalley
force-pushed
the
audio_interval_macros
branch
2 times, most recently
from
e080e6e to
76589fb
Compare
kruithofa
previously approved these changes
Dec 10, 2024
Thalley
force-pushed
the
audio_interval_macros
branch
2 times, most recently
from
0caee6e to
d78bec5
Compare
|
Rebased to solve merge conflicts |
Thalley
force-pushed
the
audio_interval_macros
branch
from
d78bec5 to
acf5afc
Compare
|
Covered a few more samples and added CONFIG_BT_GAP_AUTO_UPDATE_CONN_PARAMS=n where applicable |
Thalley
force-pushed
the
audio_interval_macros
branch
from
acf5afc to
2b16855
Compare
Thalley
force-pushed
the
audio_interval_macros
branch
from
2b16855 to
a7e1ce4
Compare
This was referenced Jan 6, 2025
Thalley
force-pushed
the
audio_interval_macros
branch
from
a7e1ce4 to
dbd4251
Compare
Thalley
force-pushed
the
audio_interval_macros
branch
7 times, most recently
from
99c98b2 to
f7716ab
Compare
Add a selection of interval values that are suitable for BAP, which will allow better coexistence between ISO and ACL, for both broadcast and unicast. Some of these are defined by the BAP spec, and some are defined by Zephyr, since they do have a suggested value from BAP. Samples and tests have been updated to use these new values. Peripheral samples have also been updated with CONFIG_BT_GAP_AUTO_UPDATE_CONN_PARAMS so that the connection parameters from the centrals aren't updated to something else shortly after. The shell has also been updated to use the LE Audio (BAP) values if audio is enabled, and the audio.conf file has disabled automatic updating of the connection parameters as the peripheral, as we rarely (if ever) want to do that. Due to the connection interval change, CI hit an issue with test_bass_broadcast_code in test_main_client_sync, where the reading of the long receive state did not finish before we attempted to do another procedure, so the function was updated to have a retry. Finally some tests were disabled as they are no longer passing. They should be reenabled once issues in the controller have been resolved. Signed-off-by: Emil Gydesen <[email protected]>
There was a bug in pa_decode_base that would would spent time parsing incoming BASEs and also update the receive states, which caused some tests to fail. This commit adds a simply check to verify that the BASE is different before spending parsing the content and updating the receive states. Signed-off-by: Emil Gydesen <[email protected]>
Thalley
force-pushed
the
audio_interval_macros
branch
from
f7716ab to
3c06ff4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a selection of interval values that are suitable for BAP,
which will allow better coexistence between ISO and ACL,
for both broadcast and unicast.
Samples and tests have been updated to use these new values.
The shell has also been updated to use the LE Audio (BAP) values
if audio is enabled, and the audio.conf file has disabled automatic
updating of the connection parameters as the peripheral, as we rarely
(if ever) want to do that.