[wip]add pinconfig and hal for gd32c10xxx #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add pin configurations for the GD32C103XX SoCs. Signed-off-by: YuLong Yao <[email protected]>
dt-bindings: add pinctrl gd32c403xx generated headers Signed-off-by: YuLong Yao <[email protected]>
gd32c103: add gd32c1xx hal code from gigadevice website. Signed-off-by: YuLong Yao <[email protected]>
hal,gd32c103:fix `timer` and `can` module Signed-off-by: YuLong Yao <[email protected]>
feilongfl
changed the title
gmarull
requested changes
Nov 30, 2021
| * SPDX-License-Identifier: Apache 2.0 | ||
| */ | ||
|
|
||
| #include "gd32c103xx-afio.h" |
There was a problem hiding this comment.
I can't see this file in this PR
Comment on lines
+39
to
+46
| /* CAN communication mode */ | ||
| #define CAN_NORMAL_MODE ((uint8_t)0x00U) /*!< normal communication mode */ | ||
| #define CAN_LOOPBACK_MODE ((uint8_t)0x01U) /*!< loopback communication mode */ | ||
| #define CAN_SILENT_MODE ((uint8_t)0x02U) /*!< silent communication mode */ | ||
| #define CAN_SILENT_LOOPBACK_MODE ((uint8_t)0x03U) /*!< loopback and silent communication mode */ | ||
|
|
||
| /* CAN timeout */ | ||
| #define CAN_TIMEOUT ((uint32_t)0x0000FFFFU) /*!< timeout value */ |
There was a problem hiding this comment.
this definitions need to be public, see https://github.com/zephyrproject-rtos/hal_gigadevice/blob/main/gd32f4xx/standard_peripheral/include/gd32f4xx_can.h#L597
nandojve
requested changes
Nov 30, 2021
There was a problem hiding this comment.
Hi @feilongfl .
You need review dt-bindings: add pinctrl gd32c103xx generated headers commit. There is mention to gd32c403xx MCU.
This can only be merged after a board be build at main repository,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
this PR add support for
gd32c10xxxdevice and oldgd32e103xxdevice.hal code from:
http://www.gd32mcu.com/cn/download/7?kw=GD32C1
-> GD32C10x Firmware Library
V1.0.1I made some modifications to hal code with reference to #6