Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom storage backend for GCS #543

Merged
merged 1 commit into from
Sep 6, 2022
Merged

Conversation

np5
Copy link
Member

@np5 np5 commented Sep 6, 2022

This is a workaround, to be able to sign blob URLs without a credential
file/private key.

References:

jschneier/django-storages#941
https://googleapis.dev/python/storage/latest/blobs.html#google.cloud.storage.blob.Blob.generate_signed_url

@coveralls
Copy link

coveralls commented Sep 6, 2022

Pull Request Test Coverage Report for Build 2999450970

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 32 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 65.554%

Changes Missing Coverage Covered Lines Changed/Added Lines %
zentral/utils/storage.py 0 1 0.0%
zentral/utils/gcs_storage.py 0 31 0.0%
Totals Coverage Status
Change from base Build 2894883779: -0.3%
Covered Lines: 24179
Relevant Lines: 36884

💛 - Coveralls

@np5 np5 merged commit 129a511 into main Sep 6, 2022
@np5 np5 deleted the 20220906_custom_gcloud_storage branch September 6, 2022 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants