test workflow #574
Merged
test workflow #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzacharo
force-pushed
the
test-workflow
branch
from
b234224 to
753d165
Compare
zzacharo
force-pushed
the
test-workflow
branch
from
753d165 to
d2b1cf3
Compare
slint
reviewed
Oct 11, 2023
site/zenodo_rdm/decorators.py
Outdated
| cache_prefix = ( | ||
| f"{key_prefix}_{current_app.config.get('IMAGE_BUILD_TIMESTAMP')}" | ||
| if current_app.config.get("IMAGE_BUILD_TIMESTAMP") is not None | ||
| else f"{key_prefix}_{datetime.datetime.now():%Y%m%d_%H%M%S}" |
There was a problem hiding this comment.
Suggested change
| else f"{key_prefix}_{datetime.datetime.now():%Y%m%d_%H%M%S}" | |
| else key_prefix |
This is a bit dangerous since you might end up adding many big keys in Redis accidentally.
For local development I would say we can use app.debug or similar to disable caching.
zzacharo
force-pushed
the
test-workflow
branch
from
d2b1cf3 to
a786470
Compare
zzacharo
force-pushed
the
test-workflow
branch
from
a786470 to
8a24db7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.