Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fetch instance view for report slices #360

Merged
merged 2 commits into from
Oct 25, 2023
Merged

fix: fetch instance view for report slices #360

merged 2 commits into from
Oct 25, 2023

Conversation

cabreraalex
Copy link
Member

Description

Fix two issues:

  • Check that chartOptions exist before selecting chart
  • Fetch instance view from string spec for rendering.

@cabreraalex cabreraalex requested a review from neubig October 25, 2023 21:41
@cabreraalex cabreraalex enabled auto-merge (squash) October 25, 2023 21:47
neubig
neubig approved these changes Oct 25, 2023
View reviewed changes
Copy link
Collaborator

@neubig neubig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me!

@cabreraalex cabreraalex merged commit 2a661ae into main Oct 25, 2023
5 checks passed
@cabreraalex cabreraalex deleted the fix-rep-slices branch October 25, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neubig neubig neubig approved these changes

Assignees

@cabreraalex cabreraalex

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cabreraalex @neubig