Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show a preview of the edited element in reports #304

Merged
merged 4 commits into from
Oct 14, 2023
Merged

Conversation

Sparkier
Copy link
Member

@Sparkier Sparkier commented Oct 13, 2023

edit.mp4

@Sparkier Sparkier self-assigned this Oct 13, 2023
@Sparkier Sparkier requested a review from cabreraalex October 14, 2023 07:57
@Sparkier Sparkier marked this pull request as ready for review October 14, 2023 07:57
}
} else if (el.type === ReportElementType.SLICE) {
if (el.data) {
sliceElementSpec = JSON.parse(el.data);
sliceOptions.then((r) => {
await sliceOptions.then((r) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this shouldn't have a then right?

@cabreraalex cabreraalex merged commit 10214d3 into main Oct 14, 2023
6 checks passed
@cabreraalex cabreraalex deleted the ab-preview branch October 14, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants