feat: update report editing workflow #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sparkier
changed the title
Sparkier
requested changes
Oct 13, 2023
| contenteditable={isEdit ? true : false} | ||
| on:blur={(e) => updateReportName(e)} | ||
| > | ||
| <h1 class="text-5xl mr-6 text-grey-darkest"> |
There was a problem hiding this comment.
How can one update the name of a report now?
Comment on lines
-152
to
-154
| {#if isEdit} | ||
| <Button variant="raised" on:click={() => addElement(elements.length)}>Add Element</Button> | ||
| {/if} |
There was a problem hiding this comment.
I think there is no way for me to add an element if there is no element in the report already now.
Sparkier
reviewed
Oct 13, 2023
Sparkier
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update report editing to match designs.
Fix ZEN-235
Screen.Recording.2023-10-12.at.14.24.49.mov