feat: add option to add slices for all values of a nominal column #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sparkier
force-pushed
the
ab-all-slices
branch
from
314f764 to
8b0d2e7
Compare
|
should we add a three dot menu next to each histogram for this? And do we want to do this for the continuous histograms? |
|
Something I thought about as well but was not sure how to do. Right now it's in the slice popup but I think I agree it might be better next to histograms. Don't know about continuous either. It's not really meaningful for continuous histograms is it? |
cabreraalex
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The slice popup changes if a user selects only a nominal column without entering anything else as follows:
After creation, slices will look as follows:
fix ZEN-214