feat: db pool for histogram calc #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
okay this is actually ready now. Very odd asyncio event loop issues in prod I was dealing with. |
cabreraalex
commented
Sep 15, 2023
| CMD exec poetry run uvicorn zeno_backend.server:get_server --reload --host 0.0.0.0 --port 80 |
There was a problem hiding this comment.
Running it as a module didn't create an event loop in asyncio oddly. Also matches the dev setup.
cabreraalex
commented
Sep 15, 2023
| return db | ||
|
|
||
|
|
||
| db_pool = AsyncConnectionPool(" ".join([f"{k}={v}" for k, v in config().items()])) |
There was a problem hiding this comment.
Eventually probably want to switch most queries to this, but it's okay to have both for now IMO
Sparkier
approved these changes
Sep 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Actually use asyncio for DB calculations using an async DB pool. Speeds up by a factor of features being calculated, e.g. 5x for translation.