Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: update python version to support types #55

Merged
merged 2 commits into from
Apr 22, 2024
Merged

build: update python version to support types #55

merged 2 commits into from
Apr 22, 2024

Conversation

Sparkier
Copy link
Member

Description

fix #54

@Sparkier Sparkier requested review from neubig and cabreraalex April 22, 2024 16:10
@Sparkier Sparkier enabled auto-merge (squash) April 22, 2024 16:10
@cabreraalex
Copy link
Member

Why require? Then if you need python less than 3.10 for like a pytorch version you won't be able to use the client

@Sparkier
Copy link
Member Author

Why require? Then if you need python less than 3.10 for like a pytorch version you won't be able to use the client

You wouldn't be able to anyway, see: #54

@cabreraalex
Copy link
Member

ah got it

@Sparkier Sparkier merged commit 8172364 into main Apr 22, 2024
1 check passed
@Sparkier Sparkier deleted the ab-python-version branch April 22, 2024 16:43
@Sparkier Sparkier restored the ab-python-version branch April 22, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cabreraalex cabreraalex cabreraalex approved these changes

@neubig neubig Awaiting requested review from neubig

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError: unsupported operand type(s) for |: 'type' and 'NoneType'
2 participants
@Sparkier @cabreraalex