Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade pnpm to >=9 #113

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

senkenn
Copy link
Contributor

@senkenn senkenn commented Jul 20, 2024

๐Ÿ“‘ Summary

  • pnpm ใŒ v9 ใซใชใฃใŸใ“ใจใง lockfile ใฎใƒ•ใ‚ฉใƒผใƒžใƒƒใƒˆใŒๅคงใใๅค‰ใ‚ใ‚Šใ€pnpm i ใ™ใ‚‹ใ ใ‘ใง lockfile ใซๅค‰ๆ›ดใŒๅ…ฅใฃใฆใ—ใพใ†ใฎใงใƒใƒผใ‚ธใƒงใƒณใ‚’ไธŠใ’ใŸใปใ†ใŒใ„ใ„ใจๆ€ใ„ใพใ—ใŸใ€‚
    image

  • 2024/7/21ๆ™‚็‚นใงใฎ latest version: v9.5.0 ใงๆ›ดๆ–ฐใ—ใพใ—ใŸใ€‚

  • Related chore: upgrade pnpm to >=9ย zenn-editor#500

๐Ÿ“‹ Tasks

ใƒ—ใƒซใƒชใ‚ฏใ‚จใ‚นใƒˆใ‚’ไฝœๆˆใ„ใŸใ ใ้š›ใ€ใŠๆ‰‹ๆ•ฐใงใ™ใŒไปฅไธ‹ใฎๅ†…ๅฎนใซใคใ„ใฆใ”็ขบ่ชใ‚’ใŠ้ก˜ใ„ใ—ใพใ™ใ€‚

  • ๐Ÿ“– Contribution Guide ใ‚’่ชญใ‚“ใ 
  • ๐Ÿ‘ฉโ€๐Ÿ’ป canary ใƒ–ใƒฉใƒณใƒใซๅฏพใ™ใ‚‹ใƒ—ใƒซใƒชใ‚ฏใ‚จใ‚นใƒˆใงใ‚ใ‚‹
  • ๅฎŸ่กŒใ—ใฆๆญฃใ—ใๅ‹•ไฝœใ—ใฆใ„ใ‚‹ใ‹็ขบ่ชใ™ใ‚‹
  • ไธ่ฆใชใ‚ณใƒผใƒ‰ใŒๅซใพใ‚Œใฆใ„ใชใ„ใ‹( ใ‚ณใƒกใƒณใƒˆใ‚„ใƒญใ‚ฐใฎๆถˆใ—ๅฟ˜ใ‚Œใซๆณจๆ„ )
  • XSS ใซใชใ‚‹ใ‚ˆใ†ใชใ‚ณใƒผใƒ‰ใŒๅซใพใ‚Œใฆใ„ใชใ„ใ‹
  • Pull Reuqest ใฎๅ†…ๅฎนใฏๅฆฅๅฝ“ใ‹( ่†จใ‚‰ใฟใ™ใŽใฆใชใ„ใ‹ )

ใ‚ˆใ‚Š่ฉณใ—ใ„ๅ†…ๅฎนใฏ Pull Request Policy ใ‚’ๅ‚็…งใ—ใฆใใ ใ•ใ„ใ€‚

@cm-igarashi-ryosuke
Copy link
Member

@senkenn ใ™ใฟใพใ›ใ‚“๏ผใ“ใกใ‚‰ใฎPRใ‚’่ฆ‹่ฝใจใ—ใฆใŠใ‚Šใพใ—ใŸใ€‚ใ“ใกใ‚‰ใฏ็งใฎๆ–นใงๅฏพๅฟœใ—ใพใ™ใฎใงใ‚ฏใƒญใƒผใ‚บใ•ใ›ใฆใ„ใŸใ ใใพใ™ ๐Ÿ™ ใ”ๆๆกˆใ‚ใ‚ŠใŒใจใ†ใ”ใ–ใ„ใพใ—ใŸใ€‚

@cm-igarashi-ryosuke
Copy link
Member

cm-igarashi-ryosuke commented Aug 21, 2024

@senkenn ใ™ใฟใพใ›ใ‚“ใ€ไธ€ๅบฆใ‚ฏใƒญใƒผใ‚บใ—ใฆใ—ใพใ„ใพใ—ใŸใŒใ€ใ“ใฎใ‚„ใ‚Šๆ–นใฏ็ฌฌไธ‰่€…ใŒ่ฆ‹ใŸใจใใซใ€Œ่ฒข็Œฎใฎๆจชๅ–ใ‚Šใซ่ฆ‹ใˆใฆใ—ใพใ†ๅฏ่ƒฝๆ€งใŒใ‚ใ‚‹ใ€ใจใƒใƒผใƒ ๅ†…ใ‹ใ‚‰ๆŒ‡ๆ‘˜ใŒใ‚ใฃใŸใŸใ‚ใ€ๅ†ใ‚ชใƒผใƒ—ใƒณใ•ใ›ใฆใ„ใŸใ ใใพใ™ใ€‚ใŠๆ‰‹ๆ•ฐใงใ™ใŒใ€ใ‚ณใƒณใƒ•ใƒชใ‚ฏใƒˆไฟฎๆญฃใฎไธŠใ€ๆ›ดๆ–ฐใ‚’ใŠ้ก˜ใ„ใ„ใŸใ—ใพใ™ ๐Ÿ™‡

@senkenn
Copy link
Contributor Author

senkenn commented Aug 21, 2024

@cm-igarashi-ryosuke ใŠๆฐ—้ฃใ„ใ‚ใ‚ŠใŒใจใ†ใ”ใ–ใ„ใพใ™๏ผใ‚ณใƒณใƒ•ใƒชใ‚ฏใƒˆ่งฃๆถˆใ„ใŸใ—ใพใ—ใŸใ€‚

@cm-igarashi-ryosuke
Copy link
Member

@senkenn ใŠๆ‰‹ๆ•ฐใ‚’ใŠใ‹ใ‘ใ„ใŸใ—ใพใ—ใŸใ€‚ใ”ๅฏพๅฟœใ‚ใ‚ŠใŒใจใ†ใ”ใ–ใ„ใพใ—ใŸ๏ผLGTMใงใ™๏ผ

@cm-igarashi-ryosuke cm-igarashi-ryosuke merged commit 79fd1e3 into zenn-dev:canary Aug 22, 2024
@senkenn senkenn deleted the chore/senkenn-pnpmv9 branch August 22, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants