Re-authenticate requests that failed authentication #3256
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe changes
When the zenml server to which a client is connected is being removed and then re-deployed to the same URL (e.g. when a ZenML Pro tenant is deactivated and then re-activated), the API token cached by the client becomes invalid (because the key used by the server to sign the API tokens changes).
When this happens, the client is expected to silently recover without throwing any errors, by leveraging other means of re-authentication at its disposal (e.g. server API key or ZenML Pro control plane authentication). However, the cached token is not currently invalidated and properly removed, which results in errors such as the following:
This PR corrects this behavior by making the client even more robust and trying requests for up to 3 times if the server responds with authentication errors:
This PR also contains a small fix to the
zenml server list
CLI command to remove inactive ZenML Pro servers from the output, unless--all
is specified.Pre-requisites
Please ensure you have done the following:
develop
and the open PR is targetingdevelop
. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes