-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify model version artifact linkage #3175
Simplify model version artifact linkage #3175
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs update is missing and old syntax was quite demoed there, so changes are needed.
Also, I left a few comments, mostly about the migration.
src/zenml/zen_stores/migrations/versions/ec6307720f92_simplify_model_version_links.py
Show resolved
Hide resolved
src/zenml/zen_stores/migrations/versions/ec6307720f92_simplify_model_version_links.py
Show resolved
Hide resolved
LLM Finetuning template updates in |
Classification template updates in |
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
NLP template updates in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The style guide flagged several spelling errors that seemed like false positives. We skipped posting inline suggestions for the following words:
- [Mm]aterializer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5 files reviewed, 1 total issue(s) found.
{% hint style="info" %} | ||
If you don't specify a type for your artifact, ZenML will use the default artifact type provided by the materializer that is used to | ||
save the artifact. | ||
{% endhint %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{% endhint %} | |
{% end %} |
Issues:
- Style Guide - (Spelling-error) Did you really mean 'endhint'?
Fix Explanation:
The term 'endhint' seems to be a typo. In documentation, especially when using hint blocks, the correct syntax to close a hint is often '{% end %}'. Therefore, replacing 'endhint' with '{% end %}' should resolve the issue.
E2E template updates in |
Describe changes
Simplifies the linking of artifact versions/pipeline runs to a model version.
Breaking changes:
is_model_artifact
andis_deployment_artifact
arguments ofsave_artifact
andregister_artifact
were replaced by an option to specify theartifact_type
Pre-requisites
Please ensure you have done the following:
develop
and the open PR is targetingdevelop
. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes