review comments

zenml-io · Nov 29, 2024 · c1b5a4c · c1b5a4c
1 parent 755c36f
commit c1b5a4c
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 19 deletions.
diff --git a/src/zenml/zen_stores/schemas/pipeline_run_schemas.py b/src/zenml/zen_stores/schemas/pipeline_run_schemas.py
@@ -297,8 +297,6 @@ def to_model(
             else {}
         )
 
-        run_metadata = self.fetch_metadata()
-
         if self.deployment is not None:
             deployment = self.deployment.to_model()
 
@@ -375,7 +373,7 @@ def to_model(
             }
             metadata = PipelineRunResponseMetadata(
                 workspace=self.workspace.to_model(),
-                run_metadata=run_metadata,
+                run_metadata=self.fetch_metadata(),
                 config=config,
                 steps=steps,
                 start_time=self.start_time,

diff --git a/src/zenml/zen_stores/schemas/step_run_schemas.py b/src/zenml/zen_stores/schemas/step_run_schemas.py
@@ -228,8 +228,6 @@ def to_model(
             RuntimeError: If the step run schema does not have a deployment_id
                 or a step_configuration.
         """
-        run_metadata = self.fetch_metadata()
-
         input_artifacts = {
             artifact.name: StepRunInputResponse(
                 input_type=StepRunInputArtifactType(artifact.type),
@@ -316,7 +314,7 @@ def to_model(
                 pipeline_run_id=self.pipeline_run_id,
                 original_step_run_id=self.original_step_run_id,
                 parent_step_ids=[p.parent_id for p in self.parents],
-                run_metadata=run_metadata,
+                run_metadata=self.fetch_metadata(),
             )
 
         resources = None

diff --git a/tests/integration/functional/utils/__init__.py b/tests/integration/functional/utils/__init__.py