Make columns non-nullable

zenml-io · Dec 9, 2024 · 882d841 · 882d841
1 parent bd5bc41
commit 882d841
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/...add_model_version_producer_run_unique_.py → ...3_add_model_version_producer_run_index.py b/...add_model_version_producer_run_unique_.py → ...3_add_model_version_producer_run_index.py
@@ -1,4 +1,4 @@
-"""Add model version producer run unique constraint [cd7b17d5a3c3].
+"""Add model version producer run index [cd7b17d5a3c3].
 
 Revision ID: cd7b17d5a3c3
 Revises: 0.71.0
@@ -28,7 +28,7 @@ def upgrade() -> None:
                 sa.Computed(
                     "name == number",
                 ),
-                nullable=True,
+                nullable=False,
             )
         )
         batch_op.add_column(
@@ -43,7 +43,7 @@ def upgrade() -> None:
                 sa.Computed(
                     "CASE WHEN producer_run_id IS NOT NULL THEN producer_run_id ELSE id END",
                 ),
-                nullable=True,
+                nullable=False,
             )
         )
         batch_op.create_index(

diff --git a/src/zenml/zen_stores/schemas/model_schemas.py b/src/zenml/zen_stores/schemas/model_schemas.py
@@ -337,7 +337,7 @@ class ModelVersionSchema(NamedSchema, RunMetadataInterface, table=True):
     )
 
     is_numeric: bool = Field(
-        sa_column=Column(BOOLEAN, Computed("name = number"))
+        sa_column=Column(BOOLEAN, Computed("name = number"), nullable=False)
     )
 
     # Don't use a foreign key here here to avoid a cycle
@@ -357,6 +357,7 @@ class ModelVersionSchema(NamedSchema, RunMetadataInterface, table=True):
             Computed(
                 "CASE WHEN producer_run_id IS NOT NULL THEN producer_run_id ELSE id END"
             ),
+            nullable=False
         )
     )