d_a_tag_kb_item OK #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Doesn't match for jpn tww? Do i have to fix something here? |
TakaRikka
reviewed
Sep 13, 2023
| } | ||
|
|
||
| /* 00000234-00000258 .text daTagKbItem_Execute__FPv */ | ||
| void daTagKbItem_Execute(void*) { | ||
| /* Nonmatching */ | ||
| static int daTagKbItem_Execute(void* i_this) { |
There was a problem hiding this comment.
ideally these return types should match the return type of the member function
There was a problem hiding this comment.
not in this case though. Objdiff shows clrlwi's that need to be generated in the static execute and static draw function. It doesn't match else
There was a problem hiding this comment.
hm, ill approve for now but i want to take a closer look at that later
There was a problem hiding this comment.
hm, ill approve for now but i want to take a closer look at that later
There was a problem hiding this comment.
hm, ill approve for now but i want to take a closer look at that later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.