More d_a_item funcs #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TakaRikka
reviewed
Sep 12, 2023
src/d/actor/d_a_item.cpp
Outdated
| @@ -322,7 +517,7 @@ s32 daItem_Delete(daItem_c* i_this) { | |||
|
|
|||
| /* 800F89D0-800F89F0 .text daItem_Create__FP10fopAc_ac_c */ | |||
| s32 daItem_Create(fopAc_ac_c* i_this) { | |||
| /* Nonmatching */ | |||
| ((daItem_c*)i_this)->_daItem_create(); | |||
There was a problem hiding this comment.
this should return the create ret value
src/d/actor/d_a_item.cpp
Outdated
Comment on lines
61
to
78
| case SKULL_NECKLACE: | ||
| return 0.0; | ||
| case BOKOBABA_SEED: | ||
| return 0.0; | ||
| case GOLDEN_FEATHER: | ||
| return 0.0; | ||
| case BOKO_BELT: | ||
| return 0.0; | ||
| case RED_JELLY: | ||
| case GREEN_JELLY: | ||
| case BLUE_JELLY: | ||
| return 0.0; | ||
| case SWORD: | ||
| return 20.0; | ||
| case SHIELD: | ||
| return 23.0; | ||
| case DROPPED_SWORD: | ||
| return 10.0; |
There was a problem hiding this comment.
are these actually double values or are they missing a f?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.