Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support all devices #179

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

Omar-D
Copy link

@Omar-D Omar-D commented Jul 31, 2024

I have made an edit on a little part of code to Support 30+ Android APIs

Thanks in Advance
All my Regards

Omar-D added 3 commits July 31, 2024 17:28
Support API +30 like A10 and etc.
Add MANAGE_EXTERNAL_STORAGE permission to Support 30+ Android APIs File Picker
@venkateswararaog-zaggle
Copy link

Thank a lot @Omar-D,

Please allow me sometime to check and merge the same

@Omar-D
Copy link
Author

Omar-D commented Aug 2, 2024

Thank a lot @Omar-D,

Please allow me sometime to check and merge the same

You'r welcome sir,
Take your time!

@Omar-D
Copy link
Author

Omar-D commented Aug 3, 2024

Thank a lot @Omar-D,

Please allow me sometime to check and merge the same

have you checked it sir?

@zeevy zeevy requested a review from Copilot November 18, 2024 06:19
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 suggestion.

Files not reviewed (1)
  • app/src/main/AndroidManifest.xml: Language not supported

Intent intent = new Intent(Settings.ACTION_MANAGE_APP_ALL_FILES_ACCESS_PERMISSION);
intent.setData(Uri.parse("package:" + getContext().getPackageName()));
startActivity(intent);
} catch (Exception e) {
Copy link
Preview

Copilot AI Nov 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Catching a generic Exception is not a best practice. Consider catching specific exceptions to improve debugging and maintenance.

Suggested change
} catch (Exception e) {
} catch (ActivityNotFoundException e) {

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants