Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export pre-commit hook #56

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Export pre-commit hook #56

merged 1 commit into from
Aug 29, 2023

Conversation

bbannier
Copy link
Member

This allows directly using this repo as a pre-commit hook.

@bbannier bbannier requested a review from awelzel August 29, 2023 07:58
@bbannier bbannier self-assigned this Aug 29, 2023
Copy link

@awelzel awelzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be useful to add an example to the README how to configure this for the non-initiated?

repos:
  - repo: https://github.com/zeek/zeekscript
    rev: topic/bbannier/pre-commit-hook
    hooks:
      - id: zeek-format

I gave it a go and it did reformat stuff :-)

.pre-commit-hooks.yaml Outdated Show resolved Hide resolved
This allows directly using this repo as a pre-commit hook.
@bbannier bbannier force-pushed the topic/bbannier/pre-commit-hook branch from dcd5830 to 8019902 Compare August 29, 2023 08:29
@bbannier
Copy link
Member Author

bbannier commented Aug 29, 2023

Might be useful to add an example to the README how to configure this for the non-initiated?

The issue is that we'd really like to document a tag for rev here and AFAIK there is no automatic tooling to keep up it up-to-date; should you know how to have update-changes only run on tags so we can replace the entry rev only for them I'd be happy to add it. If we cannot do this automatically, I'd rather not document it all to avoid stale documentation and an even more complicated release process. Also, the uninitiated might not know pre-commit autoupdate either.

@bbannier bbannier merged commit ea6c9eb into main Aug 29, 2023
7 checks passed
@bbannier bbannier deleted the topic/bbannier/pre-commit-hook branch August 29, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants