Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring parser up to date with language changes in Zeek #42

Merged
merged 5 commits into from
Nov 25, 2024

Conversation

bbannier
Copy link
Member

This PR updates the grammar so it can parse all scripts in the base distribution again, namely:

  • allow scoped IDs with more than two parts
  • allow record redefs which remove field attributes
  • add rudimentary support for @pragma

Copy link
Contributor

@evantypanski evantypanski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just an inconsequential nit, feel free to ignore :)

test/corpus/expressions Show resolved Hide resolved
This follows the approach of existing preprocessor constructs in that we
do not allow them everywhere (e.g., by adding them to `extras`), but
only if they surround fully parseable constructs like full statements.
@bbannier bbannier merged commit 26e598e into main Nov 25, 2024
2 checks passed
@bbannier bbannier deleted the topic/bbannier/zeek-catchup branch November 25, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants