Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove testing badge from README #40

Merged
merged 2 commits into from
Nov 24, 2024

Conversation

bbannier
Copy link
Member

The README is displayed e.g., on pypi.org and contained a badge to the
results of a run against the full Zeek source tree. If we display it
that prominently we should make sure to keep test passing.

Currently the parser has a number of issues parsing general Zeek script
code, especially around preprocessor constructs (e.g., nested preproc
statements, pragmas in general). Drop the status build badge, at least
until this is fixed.

The README is displayed e.g., on pypi.org and contained a badge to the
results of a run against the full Zeek source tree. If we display it
that prominently we should make sure to keep test passing.

Currently the parser has a number of issues parsing general Zeek script
code, especially around preprocessor constructs (e.g., nested preproc
statements, pragmas in general). Drop the status build badge, at least
until this is fixed.
This test has been broken for literally years and provides very little
signal. Remove it for now.
@bbannier bbannier self-assigned this Nov 23, 2024
@bbannier bbannier marked this pull request as ready for review November 23, 2024 16:13
Copy link
Contributor

@evantypanski evantypanski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does feel a little weird to advertise the broken tests :)

@bbannier bbannier merged commit 433b839 into main Nov 24, 2024
2 checks passed
@bbannier bbannier deleted the topic/bbannier/test-against-zeek-tree branch November 24, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants