Avoid implicit conversions in Zeek utility classes #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neverlord
force-pushed
the
topic/neverlord/zeek-compat-refactoring
branch
from
e618639
to
1840fd2
Compare
Neverlord
force-pushed
the
topic/neverlord/zeek-compat-refactoring
branch
from
1840fd2
to
5ac94f5
Compare
Neverlord
force-pushed
the
topic/neverlord/zeek-compat-refactoring
branch
from
5ac94f5
to
f53c768
Compare
timwoj
reviewed
Oct 10, 2023
Neverlord
force-pushed
the
topic/neverlord/zeek-compat-refactoring
branch
from
f645eb4
to
e4b0cfc
Compare
timwoj
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mainly refactors the API in
zeek.hhas preparation for the upcomingvariantswitch. However, the changes also address some rather nasty API details like implicit conversions all over the place and very verbose code in ourvalid()implementations that make it often hard to follow what's actually being checked.varianteasier, the Zeek-compatibility classes provide an interface fromdata_messagenowBatchBuildergives an interface for assembling batches without manually pulling out thedatamember from Zeek message types