Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make println utility reusable #371

Merged
merged 3 commits into from
Aug 24, 2023
Merged

Make println utility reusable #371

merged 3 commits into from
Aug 24, 2023

Conversation

Neverlord
Copy link
Member

Moves the println utility from the broker-node to the internal namespace to allow us to re-use this in other tools and benchmarks.

@Neverlord Neverlord force-pushed the topic/neverlord/println branch 2 times, most recently from 0ee393b to 76d491c Compare July 30, 2023 08:08
@Neverlord
Copy link
Member Author

@timwoj did maybe something in btest change recently? I see tons of btest suites failing on CI but this PR doesn't even touch anything remotely related to them. 🤨

@awelzel
Copy link
Contributor

awelzel commented Jul 31, 2023

I see tons of btest suites failing on CI but this PR doesn't even touch anything remotely related to them. raised_eyebrow

Downloading the artifacts for Fedora 37 and opening a few .stderr files, it looks like the broker-node process involved in the tests is segfaulting:

  1 <<< [7391] broker-node --config-file=../node.cfg                                
  2 /root/.local/bin/btest-bg-run-helper: line 25:  7393 Segmentation fault      (core dumped) broker-node --config-file=../node.cfg
  3 >>>                                                                             
  4 <<< [7451] python3 ../recv.py >recv.out                                         
  5 failed to connect to ws://localhost:1045/v1/messages/json, try again            
  ...
  1 <<< [5233] broker-node --config-file=../node.cfg                                
  2 /root/.local/bin/btest-bg-run-helper: line 25:  5235 Segmentation fault      (core dumped) broker-node --config-file=../node.cfg
  3 >>>                                                                             
  4 >>> process 5233 failed with exitcode 139: broker-node --config-file=../node.cfg

@Neverlord
Copy link
Member Author

Downloading the artifacts for Fedora 37 and opening a few .stderr files, it looks like the broker-node process involved in the tests is segfaulting:

🤦‍♂️

Sorry for the noise, should've checked myself.

@Neverlord Neverlord requested a review from timwoj August 22, 2023 15:41
@timwoj timwoj merged commit db01d8f into master Aug 24, 2023
23 checks passed
@timwoj timwoj deleted the topic/neverlord/println branch August 24, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants