windows: Improve foreground task dispatching on Windows (continued) #23415
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #22653 again
In PR #23283, I thought that every
runnable
dispatched to the main thread would correspond to anEVENT_DISPATCHED
message in the message queue. However, after testing, somerunnable
s occasionally weren’t executed.This PR updated the code as follows:
This ensures that runnables are handled more proactively on the main thread, now we handle
runnable
s with a much higher priority.A big thanks to @MolotovCherry and @ArthurBrussee for their testing efforts!
Release Notes: