fix contradictory terminology, with introduction of segment #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zancas
force-pushed
the
render-edit_zip200
branch
from
9554865
to
8a6fbee
Compare
zancas
force-pushed
the
render-edit_zip200
branch
from
8a6fbee
to
7f7de26
Compare
teor2345
reviewed
Feb 23, 2022
|
Using "block chain" in the definition is technically incorrect but this is not the right fix. We shouldn't change "branch" to "segment", because "consensus branch ID" is used all over the code and protocol spec. Changing that would be make-work, and it is not the use of "branch" that is incorrect. |
|
Given the constraint imposed by the use of the term "consensus branch ID" it seems like the best thing to do is to clarify the definition as @teor2345 proposed above. I will put this on my todo list, unless further feedback points to a better solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing terminology is contradictory, as defined
consensus brancheswould contain ancestors since block chains were defined to start from the genesis block.