Derive Serialize/Deserialize for certain simple structs #1565
Conversation
| @@ -67,7 +68,7 @@ const ZFUTURE_TX_VERSION: u32 = 0x0000FFFF; | |||
| /// that have been mined. | |||
| /// - For v5 transactions onwards, this identifier is derived only from "effecting" data, | |||
| /// and is non-malleable in all contexts. | |||
| #[derive(Clone, Copy, PartialOrd, Ord, PartialEq, Eq, Hash)] | |||
| #[derive(Clone, Copy, PartialOrd, Ord, PartialEq, Eq, Hash, Serialize, Deserialize)] | |||
There was a problem hiding this comment.
This should use hand-written Serialize and Deserialize impls that serialize to the canonical txid text string representation.
There was a problem hiding this comment.
Why? Also I dont see the definition for the canonical string rep - could you point me to it? I do see Display implemented so maybe that is it? Is there a FromStr for TxId anywhere?
There was a problem hiding this comment.
We haven't needed to implement parsing, but yes the string representation used in the Display impl is canonical.
|
@nuttycom w.r.t. Proposal and associated structs, we need it to be serializable for |
|
As per @daira 's suggestion, we will try using the protobuf encoding to do the passing back and forth. |
This PR introduces "non-controversial" derives of
SerializeandDeserializefor some structs that we persist to storage in our memory wallet implementation. This is by no means all the structs that we want to be able to serialize, but they are the ones that should be stable or are simple internal representations.