Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xtensor-zarr #23

Merged
merged 1 commit into from
Mar 24, 2021

Conversation

davidbrochart
Copy link
Contributor

No description provided.

@davidbrochart
Copy link
Contributor Author

Trigger CI

@davidbrochart davidbrochart reopened this Mar 24, 2021
@davidbrochart
Copy link
Contributor Author

It looks like the failures are due to the grid overhanging the edge of the array space, e.g. chunk 5.5.0 with shape (100, 100, 1) has unused data since only the slice (:12, :12, :1) is relevant. xtensor-zarr doesn't store the unused data, which looks like a bug.

@joshmoore
Copy link
Member

One point for zarr_implementations! 🎉 Really excited to have xtensor added here, @davidbrochart.

@davidbrochart
Copy link
Contributor Author

Indeed Josh, this exercise was useful! We have a fix coming 😄

Copy link
Collaborator

@constantinpape constantinpape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Do you want to add anything else, @davidbrochart? Otherwise I am very happy to merge this :).

Also, we should eventually add a test that reads the other zarr data with xtensor-zarr, but this is currently also lacking for the other non-python implementations, see #25.
So from my side it's totally ok to do this later in another PR.

@davidbrochart
Copy link
Contributor Author

Yes, I think we can merge this PR and I'll open another one for reading other zarr data with xtensor-zarr.

@grlee77
Copy link
Contributor

grlee77 commented Apr 7, 2021

I tried extending the data generation program to also generate an xtensor_zarr.zr3 v3 format file as well, but haven't succeeded yet. I opened an issue regarding it at xtensor-stack/xtensor-zarr#38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants