-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add xtensor-zarr #23
Add xtensor-zarr #23
Conversation
Trigger CI |
It looks like the failures are due to the grid overhanging the edge of the array space, e.g. chunk |
One point for |
Indeed Josh, this exercise was useful! We have a fix coming 😄 |
d698035
to
364296d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Do you want to add anything else, @davidbrochart? Otherwise I am very happy to merge this :).
Also, we should eventually add a test that reads the other zarr data with xtensor-zarr, but this is currently also lacking for the other non-python implementations, see #25.
So from my side it's totally ok to do this later in another PR.
Yes, I think we can merge this PR and I'll open another one for reading other zarr data with xtensor-zarr. |
I tried extending the data generation program to also generate an |
No description provided.