-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dimension_names
array metadata field
#162
Conversation
Fixes #73 |
Crosslinking #149 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@rabernat I just resolved a merge conflict which dismissed our old reviews, and mine doesn't count anymore. Could you re-approve this one please? Thanks :-) |
I don't mean to hold things up with bike-shedding, but did we reach concensus on using |
Is your intention to allow the empty string as a valid dimension name distinct from null, and not meaning an unlabeled dimension? |
My thinking was that I prefer |
@jbms As discussed last week, I changed this here to use null objects for unnamed dimensions, as requested by @shoyer. I believe this is ready to be merged now. My approval does not count anymore since I did some changes, @joshmoore could you approve this one? |
I got you @jstriebel! 🚀 |
No description provided.