Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup PCodec soft dependency #647

Merged
merged 10 commits into from
Jan 17, 2025

Conversation

jakirkham
Copy link
Member

As with other soft dependencies in Numcodecs, the pattern is to attempt to import them and if their dependencies cannot be resolved skip them. Have applied this pattern to PCodec to be consistent with the other optional codec dependencies.

TODO:

  • Unit tests and/or doctests in docstrings
  • Tests pass locally
  • Docstrings and API docs for any new/modified user-facing classes and functions
  • Changes documented in docs/release.rst
  • Docs build locally
  • GitHub Actions CI passes
  • Test coverage to 100% (Codecov passes)

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.70%. Comparing base (d8d53bb) to head (36bbed7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #647      +/-   ##
==========================================
- Coverage   99.70%   99.70%   -0.01%     
==========================================
  Files          62       62              
  Lines        2751     2749       -2     
==========================================
- Hits         2743     2741       -2     
  Misses          8        8              
Files with missing lines Coverage Δ
numcodecs/pcodec.py 100.00% <100.00%> (ø)
numcodecs/tests/test_pcodec.py 100.00% <100.00%> (ø)

@jakirkham jakirkham requested a review from dstansby November 18, 2024 20:55
@jakirkham
Copy link
Member Author

@dstansby could you please review this one?

Copy link
Contributor

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 - do you want to add a changelog if this changes behaviour for users?

@jakirkham jakirkham changed the title Cleanup PCodec soft dependency handling Cleanup PCodec soft dependency Dec 5, 2024
@jakirkham
Copy link
Member Author

Resolved conflicts and added a changelog entry

@dstansby
Copy link
Contributor

pre-commit.ci autofix

@dstansby dstansby merged commit 32545ec into zarr-developers:main Jan 17, 2025
25 of 26 checks passed
@jakirkham jakirkham deleted the fix_pcodec_soft branch January 17, 2025 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants