-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup PCodec
soft dependency
#647
Conversation
0a8d9e2
to
e7acf8d
Compare
e7acf8d
to
d1f76fc
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #647 +/- ##
==========================================
- Coverage 99.70% 99.70% -0.01%
==========================================
Files 62 62
Lines 2751 2749 -2
==========================================
- Hits 2743 2741 -2
Misses 8 8
|
@dstansby could you please review this one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 - do you want to add a changelog if this changes behaviour for users?
7808aeb
to
5ca0221
Compare
PCodec
soft dependency handlingPCodec
soft dependency
Resolved conflicts and added a changelog entry |
pre-commit.ci autofix |
As with other soft dependencies in Numcodecs, the pattern is to attempt to
import
them and if their dependencies cannot be resolved skip them. Have applied this pattern toPCodec
to be consistent with the other optional codec dependencies.TODO: