queue new apps when the manifests show up #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Temporary image deleted. |
polyrain
approved these changes
Dec 21, 2023
pkg/affected_apps/config_matcher.go
Outdated
|
|
||
| var appsSlice []v1alpha1.Application | ||
| for _, app := range argoApps.Items { | ||
| if _, ok := appsMap[app.Name]; !ok { |
There was a problem hiding this comment.
Should we log failures here under a debug log?
There was a problem hiding this comment.
This checks to see if an argo app was one of the triggered apps. It's not a failure, it just means "this app wasn't changed in this pull request". I'll change the variable names to make that obvious.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also removes the "best effort" matcher. It's highly opinionated, relies on some very specific undocumented path structure, and probably isn't best used anywhere anyway.