Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tilt local development #339

Merged
merged 1 commit into from
Dec 20, 2024
Merged

fix: tilt local development #339

merged 1 commit into from
Dec 20, 2024

Conversation

Greyeye
Copy link
Collaborator

@Greyeye Greyeye commented Dec 19, 2024

Since the grpc update and others, tilt local dev is not starting up correctly.
This will fix the issue of not starting up.

  1. specify the argocd namespace to kubechecks.
  2. set GRPC_ENFORCE_ALPN_ENABLED to false as tilt-argocd server does not have a valid cert

1. specify the argocd namespace to kubechecks.
2. set GRPC_ENFORCE_ALPN_ENABLED to false as tilt-argocd server does not have a valid cert
@zapier-sre-bot
Copy link
Collaborator

Mergecat's Review

Click to read mergecats review!

😼 Mergecat review of localdev/kubechecks/values.yaml

@@ -1,6 +1,8 @@
 configMap:
   create: true
   env:
+    GRPC_ENFORCE_ALPN_ENABLED: false
+    KUBECHECKS_ADDITIONAL_APPS_NAMESPACES: "*"
     KUBECHECKS_LOG_LEVEL: debug
     KUBECHECKS_ENABLE_WEBHOOK_CONTROLLER: "false"
     KUBECHECKS_ARGOCD_API_INSECURE: "true"
@@ -40,3 +42,6 @@ secrets:
 
 reloader:
   enabled: true
+
+argocd:
+  namespace: kubechecks

Feedback & Suggestions:

  1. Security Concern: The addition of KUBECHECKS_ADDITIONAL_APPS_NAMESPACES: "*" could potentially expose all namespaces to the application. Ensure that this is intended and consider specifying only the necessary namespaces to limit exposure. 🔒

  2. Boolean Value: The GRPC_ENFORCE_ALPN_ENABLED is set to false without quotes. For consistency and to avoid potential parsing issues, consider using quotes around boolean values, like "false". 📝

  3. Namespace Configuration: The addition of argocd.namespace: kubechecks seems to be a configuration for ArgoCD. Ensure that this does not conflict with existing configurations and that it is necessary for your deployment. 🛠️



Dependency Review

Click to read mergecats review!

No suggestions found

Copy link

github-actions bot commented Dec 20, 2024

Temporary image deleted.

@Greyeye Greyeye merged commit 05f84da into main Dec 20, 2024
3 checks passed
@Greyeye Greyeye deleted the fix-tilt branch December 20, 2024 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants