Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci build change #313

Merged
merged 1 commit into from
Nov 28, 2024
Merged

ci build change #313

merged 1 commit into from
Nov 28, 2024

Conversation

Greyeye
Copy link
Collaborator

@Greyeye Greyeye commented Nov 28, 2024

update action to push image when built by on_release_published.yaml

update action to push image when built by on_release_published.yaml
@zapier-sre-bot
Copy link
Collaborator

Mergecat's Review

Click to read mergecats review!

😼 Mergecat review of .github/workflows/on_release_published.yaml

@@ -21,3 +21,4 @@ jobs:
           image_tag: ${{ github.ref_name }}
           tag_latest: true
           token: ${{ secrets.GITHUB_TOKEN }}
+          push: true

Feedback & Suggestions:

  1. Security Consideration: Ensure that the push: true option is only used when you are certain that the build image should be pushed to a registry. Double-check that the registry credentials are securely stored and that the GITHUB_TOKEN has the necessary permissions to perform this action. 🔐

  2. Documentation: Consider adding a comment or documentation explaining the purpose of the push: true parameter. This will help future maintainers understand why this change was made and under what conditions it should be used. 📄

  3. Testing: Before merging, test this change in a safe environment to ensure that the image is pushed correctly and that no unintended side effects occur. 🧪



Dependency Review

Click to read mergecats review!

No suggestions found

Copy link

github-actions bot commented Nov 28, 2024

Temporary image deleted.

@Greyeye Greyeye merged commit f3abee0 into main Nov 28, 2024
3 checks passed
@Greyeye Greyeye deleted the fix-release-publish-build-image branch November 28, 2024 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants