support private Aws Ecr helm repositories for chart dependencies

[orenlevi111]

No description provided.

[djeebus]

If you modify the args to include something like cfg config.ServerConfig, then you can clean up some of this:

Suggested change

	s := os.Getenv("ECR_LOGIN_ENABLED")
	ecr_login_enabled, err := strconv.ParseBool(s)
	if err != nil {
	log.Fatal()
	}
	if ecr_login_enabled {
	if cfg.EcrLoginEnabled {

You can pass it into the call to GetManifestsLocal in worker.go, roughly like 110, by passing w.ctr.Config

[djeebus]

Do we need this, or is it enough to have KUBECHECKS_AWS_ECR_HOST be set to a non-empty string?

[djeebus]

I don't think we want to set this here, we'd rather allow the user to set this when running the application

[djeebus]

Suggested change

	var region = strings.SplitN(string(aws_ecr_host), ".", 6)
	var region = strings.SplitN(aws_ecr_host, ".", 6)

[djeebus]

more nitpicking:

Suggested change

	func getToken(aws_ecr_host string) (string, error) {
	func getToken(awsECRHost string) (string, error) {

[djeebus]

we'll want to return this error, as we won't want to login to the registry if we can't get a token

[djeebus]

super nitpicky:

Suggested change

	func helmLogin(tempRepoDir string, changedAppFilePath string) error {
	func helmLogin(tempRepoDir, changedAppFilePath string) error {

[KyriosGN0]

can this be applicable to also Google artifact Registry/GCR repos?

[orenlevi111]

can this be applicable to also Google artifact Registry/GCR repos?

u will need to re implement the get token function using google gcp library:
// Retrieve token for authentication against ECR registries.
func getToken(aws_ecr_host string) (string, error) {
os.Setenv("AWS_SDK_LOAD_CONFIG", "1")
var region = strings.SplitN(string(aws_ecr_host), ".", 6)
cfg, err := config.LoadDefaultConfig(context.TODO(), config.WithRegion(region[3]))
if err != nil {
return "", err
}

svc := ecr.NewFromConfig(cfg)
token, err := svc.GetAuthorizationToken(context.TODO(), &ecr.GetAuthorizationTokenInput{})
if err != nil {
	return "", err
}

authData := token.AuthorizationData[0].AuthorizationToken
data, err := base64.StdEncoding.DecodeString(*authData)
if err != nil {
	return "", err
}

parts := strings.SplitN(string(data), ":", 2)

return parts[1], nil

}

and u will need to change the hardcoded username: "AWS" from the helmLogin function, that's all.
i dont have any gcp cloud so i cannt assist here. sorry

[shlomitubul]

i take diffrent approach for gcp gar: #308