-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
skip unchanged apps #176
skip unchanged apps #176
Conversation
Temporary image deleted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I think we could break the getDiff
function up a bit since it's gotten quite large, maybe factor out the final bit of logic, but it's not necessary for this PR to go through
pkg/checks/diff/diff.go
Outdated
@@ -40,21 +40,32 @@ func isAppMissingErr(err error) bool { | |||
return strings.Contains(err.Error(), "PermissionDenied") | |||
} | |||
|
|||
//func Check(ctx context.Context, request checks.Request) (msg.Result, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should probably delete this before we merge
Signed-off-by: Joseph Lombrozo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI wants a minor change, but LGTM. Thanks for the refactor, makes it much more understandable :)
No description provided.