Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip unchanged apps #176

Merged
merged 6 commits into from
Mar 28, 2024
Merged

skip unchanged apps #176

merged 6 commits into from
Mar 28, 2024

Conversation

djeebus
Copy link
Collaborator

@djeebus djeebus commented Mar 27, 2024

No description provided.

Copy link

github-actions bot commented Mar 27, 2024

Temporary image deleted.

Copy link
Collaborator

@polyrain polyrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think we could break the getDiff function up a bit since it's gotten quite large, maybe factor out the final bit of logic, but it's not necessary for this PR to go through

@@ -40,21 +40,32 @@ func isAppMissingErr(err error) bool {
return strings.Contains(err.Error(), "PermissionDenied")
}

//func Check(ctx context.Context, request checks.Request) (msg.Result, error) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably delete this before we merge

Copy link
Collaborator

@polyrain polyrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI wants a minor change, but LGTM. Thanks for the refactor, makes it much more understandable :)

@djeebus djeebus merged commit ba8549d into main Mar 28, 2024
5 checks passed
@djeebus djeebus deleted the skip-unchanged-apps branch March 28, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants