ensure that head refs are dealt with properly #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Temporary image deleted. |
djeebus
force-pushed
the
ensure-head-is-dealt-with
branch
from
3bd9125 to
8a211f8
Compare
polyrain
approved these changes
Mar 21, 2024
ajf-zapier
reviewed
Mar 21, 2024
pkg/events/check.go
Outdated
|
|
||
| repo.BranchName = remoteHeadBranchName | ||
| ce.clonedRepos[generateRepoKey(cloneURL, remoteHeadBranchName)] = repo | ||
| } else if _, ok := ce.clonedRepos[generateRepoKey(cloneURL, "HEAD")]; !ok { |
There was a problem hiding this comment.
Maybe simplify this a bit? There's some pretty deeply-nested logic here; splitting this out and maybe using early exit might make this more readable, IMHO.
polyrain
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when a repo is cloned, it could be cloned with either a named branch OR
HEAD. in practice, they could refer to the same branch, and this MR fixes the code so they can be referenced interchangeably, when appropriate.