skip rendering hooks when none are detected

zapier · Apr 11, 2024 · ee89bce · ee89bce
1 parent de77d92
commit ee89bce
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 0 deletions.
diff --git a/pkg/checks/hooks/check.go b/pkg/checks/hooks/check.go
@@ -73,6 +73,10 @@ func Check(_ context.Context, request checks.Request) (msg.Result, error) {
 		phaseDetails = append(phaseDetails, phaseDetail)
 	}
 
+	if len(phaseNames) == 0 {
+		return msg.Result{State: pkg.StateSkip}, nil
+	}
+
 	return msg.Result{
 		State:             pkg.StateNone,
 		Summary:           fmt.Sprintf("<b>Sync Phases: %s</b>", strings.Join(toStringSlice(phaseNames), ", ")),

diff --git a/pkg/commitState.go b/pkg/commitState.go
@@ -11,6 +11,7 @@ type CommitState uint8
 // must be in order of best to worst, in order for WorstState to work
 const (
 	StateNone CommitState = iota
+	StateSkip
 	StateSuccess
 	StateRunning
 	StateWarning

diff --git a/pkg/msg/message.go b/pkg/msg/message.go
@@ -169,6 +169,10 @@ func (m *Message) BuildComment(ctx context.Context, start time.Time, commitSHA,
 				continue
 			}
 
+			if check.State == pkg.StateSkip {
+				continue
+			}
+
 			var summary string
 			if check.State == pkg.StateNone {
 				summary = check.Summary