log all errors, don't fail silently

zapier · Dec 14, 2023 · 6dfb554 · 6dfb554
1 parent da0ddd9
commit 6dfb554
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/pkg/server/hook_handler.go b/pkg/server/hook_handler.go
@@ -165,13 +165,15 @@ func (h *VCSHookHandler) processCheckEvent(ctx context.Context, repo *repo.Repo)
 	err = cEvent.MergeIntoTarget(ctx)
 	if err != nil {
 		// TODO: Cancel if gitlab etc
+		log.Error().Err(err).Msg("failed to merge into target")
 		return
 	}
 
 	// Get the diff between the two branches, storing them within the CheckEvent (also returns but discarded here)
 	_, err = cEvent.GetListOfChangedFiles(ctx)
 	if err != nil {
 		// TODO: Cancel if gitlab etc
+		log.Error().Err(err).Msg("failed to get list of changed files")
 		return
 	}
 
@@ -180,6 +182,7 @@ func (h *VCSHookHandler) processCheckEvent(ctx context.Context, repo *repo.Repo)
 	if err != nil {
 		// TODO: Cancel if gitlab etc
 		//mEvent.CancelEvent(ctx, err, "Generate List of Affected Apps")
+		log.Error().Err(err).Msg("failed to generate a list of affected apps")
 		return
 	}