feat(eslint-config): ban self and global, prefer globalThis

zanminkian · Sep 18, 2024 · 6ceacd8 · 6ceacd8
1 parent 5b49895
commit 6ceacd8
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/.changeset/polite-oranges-punch.md b/.changeset/polite-oranges-punch.md
@@ -0,0 +1,5 @@
+---
+"@git-validator/eslint-config": patch
+---
+
+feat(eslint-config): ban `self` and `global`, prefer `globalThis`
diff --git a/packages/eslint-config/src/config/javascript.ts b/packages/eslint-config/src/config/javascript.ts
@@ -271,9 +271,9 @@ export function javascript() {
         },
         globals: {
           ...Object.fromEntries(
-            Object.entries(globals.browser).filter(
-              ([k]) => !confusingKeys.includes(k),
-            ),
+            Object.entries(globals.browser)
+              .filter(([k]) => !confusingKeys.includes(k))
+              .filter(([k]) => !["self", "global"].includes(k)), // prefer `globalThis`
           ),
         },
       },