chore: add comment

zanminkian · Dec 18, 2024 · 4757af0 · 4757af0
1 parent 561ecc5
commit 4757af0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/packages/eslint-config/src/config/packagejson.ts b/packages/eslint-config/src/config/packagejson.ts
@@ -15,6 +15,7 @@ export function packagejson() {
         "pkg-json/bottom-default": "error",
         "pkg-json/exact-dependency-version": "error",
         "pkg-json/no-conflict-types": "error",
+        "pkg-json/no-dependencies-in-workspace-root": "error",
         "pkg-json/no-lifecycle-script": "error",
         "pkg-json/no-nonstandard-property": "error",
         "pkg-json/no-types-dependency-in-workspace-root": "error",
@@ -24,7 +25,6 @@ export function packagejson() {
         "pkg-json/required-hashbang": "error",
         "pkg-json/required-repository": "error",
         "pkg-json/type-module": "error",
-        "pkg-json/no-dependencies-in-workspace-root": "error",
         // "publint/suggestion": "error",
         "publint/warning": "error",
         "publint/error": "error",

diff --git a/packages/eslint-plugin-pkg-json/src/rules/required-hashbang.js b/packages/eslint-plugin-pkg-json/src/rules/required-hashbang.js
@@ -1,3 +1,5 @@
+// As a result, if the bin file have no executable permission, the cli package works well in npm and pnpm.
+// Therefore, checking the bin file starting with hashbang is enough.
 import fs from "node:fs";
 import path from "node:path";