refactor(eslint-plugin-publint,eslint-plugin-pkg-json): change export…

… default to statement
zanminkian · Sep 26, 2024 · 44584fa · 44584fa
1 parent 28edf1c
commit 44584fa
Show file tree

Hide file tree

Showing 18 changed files with 28 additions and 22 deletions.
diff --git a/.changeset/cuddly-humans-wonder.md b/.changeset/cuddly-humans-wonder.md
@@ -0,0 +1,6 @@
+---
+"eslint-plugin-pkg-json": patch
+"eslint-plugin-publint": patch
+---
+
+refactor(eslint-plugin-publint,eslint-plugin-pkg-json): change export default to statement
diff --git a/packages/eslint-plugin-pkg-json/src/processor.ts b/packages/eslint-plugin-pkg-json/src/processor.ts
@@ -1,6 +1,6 @@
 import type { Linter } from "eslint";
 
 export const processor: Linter.Processor = {
-  preprocess: (text) => [`export default ${text}`],
+  preprocess: (text) => [`(${text})`],
   postprocess: (messages) => messages[0] ?? [],
 };
diff --git a/packages/eslint-plugin-pkg-json/src/rules/bottom-default.js b/packages/eslint-plugin-pkg-json/src/rules/bottom-default.js
@@ -9,8 +9,8 @@ export const rule = {
     },
   },
   create: (context) => ({
-    "Program > ExportDefaultDeclaration ObjectExpression": (node) => {
-      if (node.parent.type === "ExportDefaultDeclaration") {
+    "Program > ExpressionStatement ObjectExpression": (node) => {
+      if (node.parent.type === "ExpressionStatement") {
         return;
       }
       const index = node.properties.findIndex((p) => p.key.value === "default");

diff --git a/packages/eslint-plugin-pkg-json/src/rules/exact-dependency-version.js b/packages/eslint-plugin-pkg-json/src/rules/exact-dependency-version.js
@@ -26,7 +26,7 @@ export const rule = {
     },
   },
   create: (context) => ({
-    "Program > ExportDefaultDeclaration > ObjectExpression": (node) => {
+    "Program > ExpressionStatement > ObjectExpression": (node) => {
       node.properties
         .filter((p) =>
           ["dependencies", "devDependencies"].includes(p.key.value),

diff --git a/packages/eslint-plugin-pkg-json/src/rules/no-conflict-types.js b/packages/eslint-plugin-pkg-json/src/rules/no-conflict-types.js
@@ -11,7 +11,7 @@ export const rule = {
     },
   },
   create: (context) => ({
-    "Program > ExportDefaultDeclaration > ObjectExpression": (node) => {
+    "Program > ExpressionStatement > ObjectExpression": (node) => {
       const dependencies = node.properties
         .filter((p) =>
           ["dependencies", "devDependencies"].includes(p.key.value),

diff --git a/packages/eslint-plugin-pkg-json/src/rules/no-dependencies-in-workspace-root.js b/packages/eslint-plugin-pkg-json/src/rules/no-dependencies-in-workspace-root.js
@@ -18,7 +18,7 @@ export const rule = {
       return {};
     }
     return {
-      "Program > ExportDefaultDeclaration > ObjectExpression": (node) => {
+      "Program > ExpressionStatement > ObjectExpression": (node) => {
         node.properties
           .filter((p) => p.key.value === "dependencies")
           .forEach((property) => {

diff --git a/packages/eslint-plugin-pkg-json/src/rules/no-lifecycle-script.js b/packages/eslint-plugin-pkg-json/src/rules/no-lifecycle-script.js
@@ -20,7 +20,7 @@ export const rule = {
     },
   },
   create: (context) => ({
-    "Program > ExportDefaultDeclaration > ObjectExpression": (node) => {
+    "Program > ExpressionStatement > ObjectExpression": (node) => {
       if (
         node.properties.find((p) => p.key.value === "private")?.value?.value ===
         true

diff --git a/packages/eslint-plugin-pkg-json/src/rules/no-nonstandard-property.js b/packages/eslint-plugin-pkg-json/src/rules/no-nonstandard-property.js
@@ -55,7 +55,7 @@ export const rule = {
     },
   },
   create: (context) => ({
-    "Program > ExportDefaultDeclaration > ObjectExpression": (node) => {
+    "Program > ExpressionStatement > ObjectExpression": (node) => {
       node.properties
         .filter((property) => !standardProperties.has(property.key.value))
         .forEach((property) => {

diff --git a/packages/eslint-plugin-pkg-json/src/rules/no-types-dependency-in-workspace-root.js b/packages/eslint-plugin-pkg-json/src/rules/no-types-dependency-in-workspace-root.js
@@ -16,7 +16,7 @@ export const rule = {
       return {};
     }
     return {
-      "Program > ExportDefaultDeclaration > ObjectExpression": (node) => {
+      "Program > ExpressionStatement > ObjectExpression": (node) => {
         node.properties
           .filter((p) =>
             ["dependencies", "devDependencies"].includes(p.key.value),

diff --git a/packages/eslint-plugin-pkg-json/src/rules/private-workspace-root.js b/packages/eslint-plugin-pkg-json/src/rules/private-workspace-root.js
@@ -16,7 +16,7 @@ export const rule = {
       return {};
     }
     return {
-      "Program > ExportDefaultDeclaration > ObjectExpression": (node) => {
+      "Program > ExpressionStatement > ObjectExpression": (node) => {
         const privateProperty = node.properties.find(
           (p) => p.key.value === "private",
         );

diff --git a/packages/eslint-plugin-pkg-json/src/rules/required-engines.js b/packages/eslint-plugin-pkg-json/src/rules/required-engines.js
@@ -17,7 +17,7 @@ export const rule = {
       return {};
     }
     return {
-      "Program > ExportDefaultDeclaration > ObjectExpression": (node) => {
+      "Program > ExpressionStatement > ObjectExpression": (node) => {
         const engines = node.properties.find((p) => p.key.value === "engines");
         if (!engines) {
           return context.report({ node, messageId: name });

diff --git a/packages/eslint-plugin-pkg-json/src/rules/required-hashbang.js b/packages/eslint-plugin-pkg-json/src/rules/required-hashbang.js
@@ -9,7 +9,7 @@ export const rule = {
     },
   },
   create: (context) => ({
-    "Program > ExportDefaultDeclaration > ObjectExpression": (node) => {
+    "Program > ExpressionStatement > ObjectExpression": (node) => {
       const bin = node.properties.find((p) => p.key.value === "bin");
       if (!bin) {
         return;

diff --git a/packages/eslint-plugin-pkg-json/src/rules/required-repository.js b/packages/eslint-plugin-pkg-json/src/rules/required-repository.js
@@ -10,7 +10,7 @@ export const rule = {
     },
   },
   create: (context) => ({
-    "Program > ExportDefaultDeclaration > ObjectExpression": (node) => {
+    "Program > ExpressionStatement > ObjectExpression": (node) => {
       if (
         node.properties.find((p) => p.key.value === "private")?.value?.value ===
         true

diff --git a/packages/eslint-plugin-pkg-json/src/rules/top-types.js b/packages/eslint-plugin-pkg-json/src/rules/top-types.js
@@ -9,8 +9,8 @@ export const rule = {
     },
   },
   create: (context) => ({
-    "Program > ExportDefaultDeclaration ObjectExpression": (node) => {
-      if (node.parent.type === "ExportDefaultDeclaration") {
+    "Program > ExpressionStatement ObjectExpression": (node) => {
+      if (node.parent.type === "ExpressionStatement") {
         return;
       }
       const index = node.properties.findIndex((p) => p.key.value === "types");

diff --git a/packages/eslint-plugin-pkg-json/src/rules/type-module.js b/packages/eslint-plugin-pkg-json/src/rules/type-module.js
@@ -9,7 +9,7 @@ export const rule = {
     },
   },
   create: (context) => ({
-    "Program > ExportDefaultDeclaration > ObjectExpression": (node) => {
+    "Program > ExpressionStatement > ObjectExpression": (node) => {
       const typeProperty = node.properties.find((p) => p.key.value === "type");
       if (!typeProperty) {
         return context.report({

diff --git a/packages/eslint-plugin-pkg-json/src/test.spec.ts b/packages/eslint-plugin-pkg-json/src/test.spec.ts
@@ -31,10 +31,10 @@ export async function test({
         .map((item) =>
           typeof item !== "string"
             ? {
-                code: `export default ${item.code}`,
+                code: `(${item.code})`,
                 filename: item.filename,
               }
-            : { code: `export default ${item}` },
+            : { code: `(${item})` },
         )
         .map(async (item) => {
           await it(item.code, () => {
@@ -51,10 +51,10 @@ export async function test({
         .map((item) =>
           typeof item !== "string"
             ? {
-                code: `export default ${item.code}`,
+                code: `(${item.code})`,
                 filename: item.filename,
               }
-            : { code: `export default ${item}` },
+            : { code: `(${item})` },
         )
         .map(async (item) => {
           await it(item.code, () => {

diff --git a/packages/eslint-plugin-publint/src/create-rule.ts b/packages/eslint-plugin-publint/src/create-rule.ts
@@ -12,7 +12,7 @@ export function createRule(type: MessageType): Rule.RuleModule {
       const filteredMessages = messages.filter((msg) => msg.type === type);
       if (filteredMessages.length <= 0) return {};
       return {
-        "Program > ExportDefaultDeclaration > ObjectExpression": (
+        "Program > ExpressionStatement > ObjectExpression": (
           node: ObjectExpression,
         ) => {
           filteredMessages.forEach((msg) => {

diff --git a/packages/eslint-plugin-publint/src/processor.ts b/packages/eslint-plugin-publint/src/processor.ts
@@ -1,6 +1,6 @@
 import type { Linter } from "eslint";
 
 export const processor: Linter.Processor = {
-  preprocess: (text) => [`export default ${text}`],
+  preprocess: (text) => [`(${text})`],
   postprocess: (messages) => messages[0] ?? [],
 };