feat(eslint-config): remove __dirname and __filename in globals

zanminkian · Sep 19, 2023 · 2b7cf18 · 2b7cf18
1 parent 84c69bb
commit 2b7cf18
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/.changeset/tasty-ghosts-sort.md b/.changeset/tasty-ghosts-sort.md
@@ -0,0 +1,5 @@
+---
+"@git-validator/eslint-config": patch
+---
+
+feat(eslint-config): remove `__dirname` and `__filename` in globals
diff --git a/packages/eslint-config/README.md b/packages/eslint-config/README.md
@@ -14,6 +14,7 @@ A strict eslint config for better code quality. Based on [standard.js](https://g
 - One-line of config.
 - Work well with Prettier without conflicts.
 - Designed to work with TypeScript, NestJS and React out-of-box.
+- Modern. ESM first.
 
 ## Usage
 

diff --git a/packages/eslint-config/src/base.js b/packages/eslint-config/src/base.js
@@ -19,8 +19,6 @@ export default [
       globals: {
         ...globals["shared-node-browser"],
         ...globals.browser, // TODO Optimize it. Node code should not use browser's objects.
-        __dirname: false, // TODO Remove it
-        __filename: false, // TODO Remove it
       },
     },
     linterOptions: {