chore(core): add asserts on in and out LweDimension to check they match #992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
IceTDrinker
commented
Mar 15, 2024
IceTDrinker
commented
- ran into an issue where the dimensions did not agree and got weird results because of that
mayeul-zama
reviewed
Mar 15, 2024
tfhe/src/core_crypto/algorithms/lwe_programmable_bootstrapping.rs
Outdated
Show resolved
Hide resolved
- ran into an issue where the dimensions did not agree and got weird results because of that
IceTDrinker
force-pushed
the
am/chore/add-assert-for-lwe-dim-pbs
branch
from
5b77464 to
422e155
Compare
mayeul-zama
approved these changes
Mar 15, 2024
multi bit PBS already had it as far as I could see |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.